Relationships references should follow bigint ids schema as well #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolfDan
changed the title
Contributor
|
Interesting, so I don't think this would be quite enough. We would only want to make the integer a bigint if the other end would also be a bigint. But there are two points worth mentioning: 1.) we should just default |
Contributor
|
I'll go ahead and make those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
On my previous PR I modified the integer primary keys to generate a
bigserialid, while the test was successful I didn't take into account relationships which should bebigintas well, so this PR aims to solve thatMy worry here is the lack of tests regarding this, I'm not really familiar with the way you test things here @zachdaniel so a bit of help/guidance would be appreciated ^^/